error delivering without team member review

Susan Hanson (1.6k●2●191●193) | asked Jul 04 '13, 9:29 a.m.

We have a requirement that code delivery must have a Review by a team member. Yesterday, someone got a non-team member to review and then attempted delivery, instead of a nice error, he got this:
"internal error occurred during Computing Team Advisor Details".
When he attempted to find out what requirement wasn't met, he got a null pointer error. After getting a team member to review, he got past this. However, we are wondering what caused the NPE and if there is a fix available?

The .metadata/.log file ends with:

!ENTRY org.eclipse.core.jobs 4 2 2013-07-03 15:30:06.847
!MESSAGE An internal error occurred during: "Computing Team Advisor details...".
!STACK 0
java.lang.NullPointerException
    at java.lang.String$CaseInsensitiveComparator.compare(String.java:53)
    at java.lang.String$CaseInsensitiveComparator.compare(String.java:38)
    at com.ibm.team.filesystem.internal.rcp.ui.workitems.deliveradvisor.RequiredWorkItemApprovalDetailProvider$RequirementFailureComparator.compare(RequiredWorkItemApprovalDetailProvider.java:89)
    at com.ibm.team.filesystem.internal.rcp.ui.workitems.deliveradvisor.RequiredWorkItemApprovalDetailProvider$RequirementFailureComparator.compare(RequiredWorkItemApprovalDetailProvider.java:1)
    at java.util.TreeMap.compare(TreeMap.java:1188)
    at java.util.TreeMap.put(TreeMap.java:531)
    at java.util.TreeSet.add(TreeSet.java:255)
    at com.ibm.team.filesystem.internal.rcp.ui.workitems.deliveradvisor.RequiredWorkItemApprovalDetailProvider.getFailedRequirements(RequiredWorkItemApprovalDetailProvider.java:204)
    at com.ibm.team.filesystem.internal.rcp.ui.workitems.deliveradvisor.RequiredWorkItemApprovalDetailProvider.appendProblem(RequiredWorkItemApprovalDetailProvider.java:114)
    at com.ibm.team.filesystem.ide.ui.process.AbstractSourceControlAdvisorDetailProvider.createDetailText(AbstractSourceControlAdvisorDetailProvider.java:95)
    at com.ibm.team.process.ide.ui.advice.AdviceElementDetailProvider.getDetailText(AdviceElementDetailProvider.java:128)
    at com.ibm.team.process.internal.ide.ui.advice.TeamAdvisorView$8.run(TeamAdvisorView.java:527)
    at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)

Accepted answer

permanent link

Tim Mok (6.6k●3●8) | answered Jul 04 '13, 11:00 a.m.
JAZZ DEVELOPER

This is a bug. The precondition failed because of the non-team member providing the approval on the work item. It doesn't satisfy the precondition requirements.

Susan Hanson selected this answer as the correct answer

Comments

Susan Hanson commented Jul 04 '13, 6:45 p.m.

Yea, we knew that the original problem was the non-team member pre-condition but were wondering if we needed to open a bug/pmr or if this was already known and fixed (we are back on 4001). I'll confirm the eclipse client level with the person who had this when he is back from holidays on Monday and then will open the bug. We've had the pre-condition in there for awhile and never saw it, so maybe it is something that was working in 301 and broke in 4001.

Tim Mok commented Jul 05 '13, 8:43 a.m.

JAZZ DEVELOPER

It looks like a bug to me. Although, I tried to reproduce it but it didn't give me an error. It could be something more specific to trigger the error and the current code looks like it's possible to get this kind of error.

It's all about the answers!

Related questions

error delivering without team member review

Accepted answer

Your answer