It's all about the answers!

Ask a question

Support for code reviews


Mark Macdonald (622) | asked Jun 06 '08, 2:22 p.m.
Does Jazz (or RTC) have support for code reviews? Specifically, I want to be able to:

- Send diffs to team members, and possibly others outside the team
- Allow reviewers to annotate the diffs with comments on a line-by-line basis
- View comments left by other reviewers

2 answers



permanent link
Andrew Hoo (1.0k1) | answered Jun 06 '08, 6:02 p.m.
JAZZ DEVELOPER
Yes, there is support for code reviews through work items.

You can think of change sets as first class diff objects. To 'send' a change set to a team member for review you would:

1. Create a new work item with the appropriate reviewers subscribed.

2. Close and attach the change set to the work item. Closing the change set means you're not going to be editing the files that your team mates are reviewing.

3. Your team (or anybody else you want) can accept the change set into their repository workspace through the work item's 'links' page. Notice that the change set was not delivered to a stream, meaning it won't affect the entire team (and build systems, etc). The best part is that it's actually in their repository workspace and not just in a review item. It's easy for them to run your code, test it, and discard it afterwards (so they don't mess up their own work).

4. Your team mates comment directly back in the work item, and can approve/reject the work item's status.


Unfortunately, the reviewers cannot annotate the change set line-by-line. The best they could do is create a new change set ontop of this, and annotate the file, and also attach this to the work item. I don't recommend this though because you'll have to remember not to deliver those change sets!

Also, note that if you find your code needs more work, your new edits go into a new change set (since you closed the last one). You can attach these change sets to the same approval work item, and just ping your team members to have them grab those change sets as well to start the review process over again.

permanent link
Andrew Hoo (1.0k1) | answered Jun 06 '08, 6:04 p.m.
JAZZ DEVELOPER
Also, the approval work items on the change sets can be processed enabled. Meaning you can do things like restrict delivery to the stream unless you have two team members who have approved the work items.

Your answer


Register or to post your answer.


Dashboards and work items are no longer publicly available, so some links may be invalid. We now provide similar information through other means. Learn more here.