On 2011/01/06 9:23, bariserdemir wrote:

Are there any code review facility in RTC scm manager? Any workaround
solution for this porpose?

On our team, we require that all changes be reviewed before being
delivered. We accomplish that in RTC as follows:
1. The owner of the work item creates an approval on the work item of
type Review, with the approver set to the person who should review the
changes.
2. The reviewer notices the review request from the e-mail message or
the event in his event feed.
3. The reviewer goes to the work item and looks at the change sets in
the Change Explorer view. Sometimes the reviewer will accept the change
sets into his workspace so he can have a closer look, but looking at
them in the change explorer is usually good enough.
4. The review adds any comments from the review to the work item and
approves or rejects the approval.
5. The owner delivers the changes, or deals with any comments and
restarts the process.

It's not perfect, but it works well enough for us. Different teams have
very different ideas of what is involved in a code review, so this won't
work for everyone.

What specifically are you looking for in a code review facility?

--
David Olsen
IBM Rational

Hi David, thanks for the answer.
I am looking for an automated review.
I have criteria for java source codes.
What I expect from RTC is:
in delivery, or when triggered; analyze the source code and add comments on code, e-mail if any violation detected and create work item automatically.

I know that I can have those by extending RTC. Is it possible having this functions without extending RTC?
Thank you

What specifically are you looking for in a code review facility?

Nothing like that is in RTC out of the box. You're probably looking for something like Rational Software Analyzer. I believe it has advisors that can run before delivery that may provide what you are looking for. There are also IBM business partners that provide code review tools that integrate with RTC.

http://jazz.net/community/ensemble/index.jsp?p=partnerPlugins

Thanks for the tip. This is what we are planning to use for my project. Is there a way to not allow user to approve/review his own changes?
Currently anyone in the team can review the code including the submitter and we don't want that.

On 2011/01/06 9:23, bariserdemir wrote:

Are there any code review facility in RTC scm manager? Any workaround
solution for this porpose?

On our team, we require that all changes be reviewed before being
delivered. We accomplish that in RTC as follows:
1. The owner of the work item creates an approval on the work item of
type Review, with the approver set to the person who should review the
changes.
2. The reviewer notices the review request from the e-mail message or
the event in his event feed.
3. The reviewer goes to the work item and looks at the change sets in
the Change Explorer view. Sometimes the reviewer will accept the change
sets into his workspace so he can have a closer look, but looking at
them in the change explorer is usually good enough.
4. The review adds any comments from the review to the work item and
approves or rejects the approval.
5. The owner delivers the changes, or deals with any comments and
restarts the process.

It's not perfect, but it works well enough for us. Different teams have
very different ideas of what is involved in a code review, so this won't
work for everyone.

What specifically are you looking for in a code review facility?

--
David Olsen
IBM Rational