Welcome to the Jazz Community Forum
Code Review process
Hi,
I need your help designing our Code Review process.
Our system:
- Cobol files
- we have one Code Reviewer that verifies code quality
- today, every approved file get checksum that enable delivering it to production
- every approved file gets grade of the code quality
- Code Reviewer must have the submitted date of the Code Review request.
I need your help to implement this process in RTC.
I know:
1) we can't verify single file RTC works with Change-sets.
2) I know we can only approve Work-item and not single Change-set
3) There is Code review approval in Work-item.
My solution (with my problem description):
1. Developer create Chang-sets and relate them to Work-item
2. Developer change Work-item state to "In Code Review"
3. Code Reviewer get list of Work-items in state "In Code Review"
4. Code Reviewer verify all Change-sets related to the Work-item
5. Code Reviewer add comment to Work-item if he want the developer to fix a file, and change state to Rejected.
6. Developer get Work-items in Rejected state, fix the file and change back the state to "In Code Review"
7. Code Reviewer get back the Work-item and approve the Work item by adding Code Review Approval
8. There is precondition (advisor) that enable deliver operation only if the related Work-item is approved.
9. There is precondition (advisor) that disable "relate change-set" option if the Work-item in closed state.
10. I made participant that clears the approval on change state to "In Progress"
This process ensures that our stream will contain only Change-sets that related to approval Work-items.
The problems:
The change-set is still open after approving the related Work-item, so the developer can modify and check-in the file but it is still approved.
If I could complete the change-sets related to Work-item on state change to "Approved" it will solve my problem
'submit for review' action will cause many unwanted change-sets and completed environment on fix action (if the Code Reviewer ask for fix, than the developer need to create another change-set).
I got answer in the forum that I can't make advisor for check-in operation (if it was possible, I would disable checkin to approved work-item).
I'm just asking what is the Code Review process in RTC (I assume there is such an important process..)
We started the pilot but we still dont have completed Code Review process so it is critical.
Please help,
Yehiel
I need your help designing our Code Review process.
Our system:
- Cobol files
- we have one Code Reviewer that verifies code quality
- today, every approved file get checksum that enable delivering it to production
- every approved file gets grade of the code quality
- Code Reviewer must have the submitted date of the Code Review request.
I need your help to implement this process in RTC.
I know:
1) we can't verify single file RTC works with Change-sets.
2) I know we can only approve Work-item and not single Change-set
3) There is Code review approval in Work-item.
My solution (with my problem description):
1. Developer create Chang-sets and relate them to Work-item
2. Developer change Work-item state to "In Code Review"
3. Code Reviewer get list of Work-items in state "In Code Review"
4. Code Reviewer verify all Change-sets related to the Work-item
5. Code Reviewer add comment to Work-item if he want the developer to fix a file, and change state to Rejected.
6. Developer get Work-items in Rejected state, fix the file and change back the state to "In Code Review"
7. Code Reviewer get back the Work-item and approve the Work item by adding Code Review Approval
8. There is precondition (advisor) that enable deliver operation only if the related Work-item is approved.
9. There is precondition (advisor) that disable "relate change-set" option if the Work-item in closed state.
10. I made participant that clears the approval on change state to "In Progress"
This process ensures that our stream will contain only Change-sets that related to approval Work-items.
The problems:
The change-set is still open after approving the related Work-item, so the developer can modify and check-in the file but it is still approved.
If I could complete the change-sets related to Work-item on state change to "Approved" it will solve my problem
'submit for review' action will cause many unwanted change-sets and completed environment on fix action (if the Code Reviewer ask for fix, than the developer need to create another change-set).
I got answer in the forum that I can't make advisor for check-in operation (if it was possible, I would disable checkin to approved work-item).
I'm just asking what is the Code Review process in RTC (I assume there is such an important process..)
We started the pilot but we still dont have completed Code Review process so it is critical.
Please help,
Yehiel
4 answers
Hi,
I need your help designing our Code Review process.
Our system:
- Cobol files
- we have one Code Reviewer that verifies code quality
- today, every approved file get checksum that enable delivering it to production
- every approved file gets grade of the code quality
- Code Reviewer must have the submitted date of the Code Review request.
I need your help to implement this process in RTC.
I know:
1) we can't verify single file RTC works with Change-sets.
2) I know we can only approve Work-item and not single Change-set
3) There is Code review approval in Work-item.
My solution (with my problem description):
1. Developer create Chang-sets and relate them to Work-item
2. Developer change Work-item state to "In Code Review"
3. Code Reviewer get list of Work-items in state "In Code Review"
4. Code Reviewer verify all Change-sets related to the Work-item
5. Code Reviewer add comment to Work-item if he want the developer to fix a file, and change state to Rejected.
6. Developer get Work-items in Rejected state, fix the file and change back the state to "In Code Review"
7. Code Reviewer get back the Work-item and approve the Work item by adding Code Review Approval
8. There is precondition (advisor) that enable deliver operation only if the related Work-item is approved.
9. There is precondition (advisor) that disable "relate change-set" option if the Work-item in closed state.
10. I made participant that clears the approval on change state to "In Progress"
This process ensures that our stream will contain only Change-sets that related to approval Work-items.
The problems:
The change-set is still open after approving the related Work-item, so the developer can modify and check-in the file but it is still approved.
If I could complete the change-sets related to Work-item on state change to "Approved" it will solve my problem
'submit for review' action will cause many unwanted change-sets and completed environment on fix action (if the Code Reviewer ask for fix, than the developer need to create another change-set).
I got answer in the forum that I can't make advisor for check-in operation (if it was possible, I would disable checkin to approved work-item).
I'm just asking what is the Code Review process in RTC (I assume there is such an important process..)
We started the pilot but we still dont have completed Code Review process so it is critical.
Please help,
Yehiel
Hi,
you could create an advisor that uses a custom state instead of a state group and prevents adding change sets. Or you could add the review state to the closed state group.
You could probably also write an advisor that does only allow associating a completed change set. I think you want completed change sets because they can't be modified. In addition a completed change set can be accepted into the reviewers workspace.
If a review results in new changes the developer would have to add a new completed change set to the work item. The reviewer would accept all change sets to get the cumulative state. You get more change sets, but all is clean.
Another approach would be that the developer has not the right to deliver to the final prod stream and an integrator accepts and delivers the changes that are approved.
Hi,
If the Code Reviewer wants correction, the developer will create a new Change-set containing this correction. But after the Code Reviewer approves the Work-item, the developer can only deliver the first bad Chang-set (without the correction). Is there a way to tie the first Change-set with its corrections Change-sets?
Thanks.
If the Code Reviewer wants correction, the developer will create a new Change-set containing this correction. But after the Code Reviewer approves the Work-item, the developer can only deliver the first bad Chang-set (without the correction). Is there a way to tie the first Change-set with its corrections Change-sets?
Thanks.
