It's all about the answers!

Ask a question

Does RTC support "All changes must be reviewed"?


Chris Zardis (6134) | asked Oct 10 '11, 11:03 a.m.
I have created a review process in RTC that goes something along the lines of the following (many details omitted as they are unimportant)...

1) Developer changes code
2) Developer gets code reviewed - No change sets can be attached once the work item goes up for review
3) Developer delivers changes

Our requirement is to ensure that all changes are reviewed when they are delivered. In order to achieve this we believed it was sufficient to prevent change sets from being attached to the work item once the work item was in review state. However, it seems there are two ways of creating a review, one of which can result in change sets remaining active after the review...

1) Right click change set(s) > Submit for review.
- This creates an approval on the work item and completes change set(s).

2) Go to the approvals tab and manually create a review
- This only creates an approval on the work item (change sets remain active until developer completes them manually or they deliver the change sets)

The issue is that, if developers go for option number 2, the following is possible...

1) Developer changes code
2) Developer gets code reviewed - No change sets can be attached once the work item goes up for review
3) Developer adds lots of new code (unintentionally or otherwise) to existing active change sets - this does not get reviewed
4) Developer delivers changes (including un-reviewed code)

Is this requirement (to ensure that all changes are reviewed) supported by RTC? If not, I believe it would be a good enhancement, as I can imagine many teams having a similar requirement. It would be useful to have either a pre-condition to check that change sets are complete in certain states or to have an action that allows RTC to automatically complete all change sets after a review or other workflow action has taken place.

2 answers



permanent link
Geoffrey Clemm (30.1k33035) | answered Oct 10 '11, 11:53 a.m.
FORUM ADMINISTRATOR / FORUM MODERATOR / JAZZ DEVELOPER
This enhancement is work item 177378.
Please feel free to add a comment indicating your interest/support.

Cheers,
Geoff

On 10/10/2011 11:08 AM, czardis wrote:
I have created a review process in RTC that goes something along the
lines of the following (many details omitted as they are
unimportant)...

1) Developer changes code
2) Developer gets code reviewed - No change sets can be attached once
the work item goes up for review
3) Developer delivers changes

Our requirement is to ensure that all changes are reviewed when they
are delivered. In order to achieve this we believed it was sufficient
to prevent change sets from being attached to the work item once the
work item was in review state. However, it seems there are two ways
of creating a review, one of which can result in change sets
remaining active after the review...

1) Right click change set(s)> Submit for review.
- This creates an approval on the work item and completes change
set(s).

2) Go to the approvals tab and manually create a review
- This only creates an approval on the
work item (change sets remain active until developer completes them
manually or they deliver the change sets)

The issue is that, if developers go for option number 2, the following
is possible...

1) Developer changes code
2) Developer gets code reviewed - No change sets can be attached once
the work item goes up for review
3) Developer adds lots of new code (unintentionally or otherwise) to
existing active change sets - this does not get reviewed
4) Developer delivers changes (including un-reviewed code)

Is this requirement (to ensure that all changes are reviewed)
supported by RTC? If not, I believe it would be a good enhancement,
as I can imagine many teams having a similar requirement. It would be
useful to have either a pre-condition to check that change sets are
complete in certain states or to have an action that allows RTC to
automatically complete all change sets after a review or other
workflow action has taken place.

permanent link
Chris Zardis (6134) | answered Oct 11 '11, 4:47 a.m.
Thanks very much for this Geoff

Your answer


Register or to post your answer.


Dashboards and work items are no longer publicly available, so some links may be invalid. We now provide similar information through other means. Learn more here.