Jazz Forum Welcome to the Jazz Community Forum Connect and collaborate with IBM Engineering experts and users

Does RTC support "All changes must be reviewed"?

I have created a review process in RTC that goes something along the lines of the following (many details omitted as they are unimportant)...

1) Developer changes code
2) Developer gets code reviewed - No change sets can be attached once the work item goes up for review
3) Developer delivers changes

Our requirement is to ensure that all changes are reviewed when they are delivered. In order to achieve this we believed it was sufficient to prevent change sets from being attached to the work item once the work item was in review state. However, it seems there are two ways of creating a review, one of which can result in change sets remaining active after the review...

1) Right click change set(s) > Submit for review.
- This creates an approval on the work item and completes change set(s).

2) Go to the approvals tab and manually create a review
- This only creates an approval on the work item (change sets remain active until developer completes them manually or they deliver the change sets)

The issue is that, if developers go for option number 2, the following is possible...

1) Developer changes code
2) Developer gets code reviewed - No change sets can be attached once the work item goes up for review
3) Developer adds lots of new code (unintentionally or otherwise) to existing active change sets - this does not get reviewed
4) Developer delivers changes (including un-reviewed code)

Is this requirement (to ensure that all changes are reviewed) supported by RTC? If not, I believe it would be a good enhancement, as I can imagine many teams having a similar requirement. It would be useful to have either a pre-condition to check that change sets are complete in certain states or to have an action that allows RTC to automatically complete all change sets after a review or other workflow action has taken place.

0 votes



2 answers

Permanent link
This enhancement is work item 177378.
Please feel free to add a comment indicating your interest/support.

Cheers,
Geoff

On 10/10/2011 11:08 AM, czardis wrote:
I have created a review process in RTC that goes something along the
lines of the following (many details omitted as they are
unimportant)...

1) Developer changes code
2) Developer gets code reviewed - No change sets can be attached once
the work item goes up for review
3) Developer delivers changes

Our requirement is to ensure that all changes are reviewed when they
are delivered. In order to achieve this we believed it was sufficient
to prevent change sets from being attached to the work item once the
work item was in review state. However, it seems there are two ways
of creating a review, one of which can result in change sets
remaining active after the review...

1) Right click change set(s)> Submit for review.
- This creates an approval on the work item and completes change
set(s).

2) Go to the approvals tab and manually create a review
- This only creates an approval on the
work item (change sets remain active until developer completes them
manually or they deliver the change sets)

The issue is that, if developers go for option number 2, the following
is possible...

1) Developer changes code
2) Developer gets code reviewed - No change sets can be attached once
the work item goes up for review
3) Developer adds lots of new code (unintentionally or otherwise) to
existing active change sets - this does not get reviewed
4) Developer delivers changes (including un-reviewed code)

Is this requirement (to ensure that all changes are reviewed)
supported by RTC? If not, I believe it would be a good enhancement,
as I can imagine many teams having a similar requirement. It would be
useful to have either a pre-condition to check that change sets are
complete in certain states or to have an action that allows RTC to
automatically complete all change sets after a review or other
workflow action has taken place.

0 votes


Permanent link
Thanks very much for this Geoff

0 votes

Your answer

Register or log in to post your answer.

Dashboards and work items are no longer publicly available, so some links may be invalid. We now provide similar information through other means. Learn more here.

Search context
Follow this question

By Email: 

Once you sign in you will be able to subscribe for any updates here.

By RSS:

Answers
Answers and Comments
Question details

Question asked: Oct 10 '11, 11:03 a.m.

Question was seen: 8,701 times

Last updated: Oct 10 '11, 11:03 a.m.

Confirmation Cancel Confirm