It's all about the answers!

Ask a question

Code Review EWM 7.0.2 - Is it possible to change the work flow from "All" Reviewers to "Any"?


Dave Valliere (11) | asked Mar 24, 8:08 a.m.

Code Review EWM 7.0.2 - Is it possible to change the work flow from "All" Reviewers to "Any"?

My understanding is that if an author asked two reviewers to participate in a code review  then both reviewers have to complete that code review before the author can proceed and deliver the change sets.

Is it possible to make this All work flow to use any ?  This would be that the author asks two people for a review and if one of the reviewers approves it - the author can deliver ?

-Dave

4 answers



permanent link
Shashikant Padur (4.2k27) | answered Mar 25, 12:32 a.m.
JAZZ DEVELOPER
edited Mar 25, 12:35 a.m.
Currently it is not possible but you can raise and enhancement request. This change will effect the code review workflow and needs impact needs to be assessed.
As a workaround, you can achieve this functionality by removing the second reviewer after the first reviewer approves the review. The second reviewer status will change to 'Abandoned' and the code review status will change from 'InReview' to 'Approved'.

permanent link
Vishal Gupta (311) | answered Mar 25, 2:48 a.m.
JAZZ DEVELOPER
edited Mar 25, 3:10 a.m.

If you are only interested in restricting change set delivery based of number of code reviewers, we have one out-of-the-box deliver precondition "Require Work Item Approval" where you can mention how many reviewers should approve the code review before change sets linked to the work item can be delivered.
For example, if there are 2 code reviewers and in the precondition you have set "only 1 code review approval required from change set delivery ", so in this case you will be able to deliver your change set if one of the reviewers approves the review. Of course, overall code review status will still be "In Review" as 2nd reviewer has not completed his/her review.


permanent link
Dave Valliere (11) | answered Mar 29, 3:01 p.m.

 Visal ,

   Thanks for your response.  I have included two screen shots.  One shows the developer deliver precondition.  We do have the "Require Work Item Approval"  limited to 1 approval. 

   The second screen shot is how we have the code review in EQM 7.0.2 configured now.

    When a  Developer asks for 2 people to  Review a change set if 1 Reviewer Approves the Code review the Developer can deliver after his/her first Approval correct ?  Can you share how this would work ?

   Is there anything else I would need to change ?

-Dave


Comments
Ralph Schoon commented Mar 30, 4:16 a.m.
FORUM ADMINISTRATOR / FORUM MODERATOR / JAZZ DEVELOPER

Try using Chrome to upload images. 


permanent link
Vishal Gupta (311) | answered Mar 30, 4:02 a.m.
JAZZ DEVELOPER

Dave,
I do not see any screen shots attached. Can you try uploading it again. If it is a permission issue, can you upload the screenshot somewhere and paste the link here.


Comments

Vishal Gupta commented Mar 31, 3:56 a.m.
JAZZ DEVELOPER

You have setup the precondition correctly. But looking at the 2nd screenshot, it is not clear if you have configured your project area for code review correctly. Are you able to submit your change sets for code review? Also, are reviewers able to open a code review to approve/return it.
If you have not configured code review for the project area, You can use the following link to configure your project area for code review.
https://www.ibm.com/docs/en/elm/7.0.3?topic=tool-configuring-your-project-area-code-review
If the code review workflow is setup as expected, then you can try to deliver a change set where both the reviewers have not approved in the code review. This delivery will fail. Now if one of the reviewer approves the code review, and then you try to deliver the change set, it will succeed. Let me know if it doesn't work as expected.

Your answer


Register or to post your answer.