What is best practice to deal with ChageSet for which Review is rejected
Hello Team,
Here My Scenario,
Team Leader - X & Developer - Y.
Y created a New ChangeSet and associated with the WorkItem. After associating, Y will select Submit For Review to X. After Selecting the Submit For Review option the ChangeSet become Complete. Then X will Review the file and Reject it.
My question is, How to deal with the Rejected ChangeSet? Is there any best practice to handle Rejected ChangeSet?
Regards,
Kiran
One answer
The recommended practice is to create a new change set which addresses (fixes) the review comments from the initial change set, and attach that new change set to the work item as well. The comment of the new change set can be something like "addressed review comments" to make it more clear for everyone.
Depending on your internal process, you can then create another review request on the work item, or ping the original reviewer and tell him you have attached another change set which fixes the original issue (after they review it, they may choose to change the "Rejected" status to "Approved").
Note: Keeping all change sets is recommend for audit/tractability purposes.