Forcing and making code reviews

Hi, Amir.

You can do this by configuring a precondition that is checked on the
client when change sets are delivered. To do this for the entire project:
1. Open the project area editor and go to the Process Configuration tab.
2. Select the "Operation Behavior" node in the "Team Configuration" section.
3. Scroll down to the Source Control section and click on the table cell
at "Deliver (client)" row and the "Everyone (default)" column.
4. Click the checkbox to configure preconditions and followup actions
and then select "Add..." in the preconditions section. Select the
"Require Work Item Approval" precondition and click OK.
5. In the section for Required Approvals, click the "New..." button. In
this dialog select the "Review" type and set approvers to 1 team lead.

There is no explicit support for review comments yet, but I posted some
tips on this topic earlier today in the thread here:
https://jazz.net/forums/viewtopic.php?t=1102

Jared Burns
Jazz Process Team


abaror wrote:

How do I force review of all deliveries? Forcing the code to be
reviewed by the team-lead? Also, is there support for review
comments?

Can a team-lead than delegate the review of a specific workitem to another team member?

Hello,

The work item would need to be reviewed by someone with the team-lead role to pass the precondition. So, a team-lead could delegate to another team-lead, but not to someone without that role.

Martha
Jazz Team Developer

There's no explicit notion of delegating reviews, but you could
accomplish this by configuring your precondition to require a team-lead
approval *and* a team-member approval.

Then your team could work like this:
1. Team member A attaches a change set to a work item and creates a
review request for the team-lead.
2. The team-lead sees this request in Team Central and decides to
delegate the review to team member B. The team-lead marks the team-lead
review as completed and creates a new review for team-member B.
3. Team member B reviews the changes and marks their review as completed.
4. With both reviews in hand, team member A can deliver the changes.

Jared Burns
Jazz Process Team


abaror wrote:

Can a team-lead than delegate the review of a specific workitem to
another team member?

We tried exactly this process , I created the rule and allowed to override the review. After I approved, my team member tried to deliver the workitem , however it was rejected by the rules that requires approval. Looking again on the workitem, we can see it is approved.
He was able to deliver it , but choosing to overrule the the review.

Is that a known defect or we are doing something wrong?

What also is strange, that he can open the workitem and remove the required approvals.

Hi, Amir.

If I understand the situation correctly, it sounds like you might have a
configuration problem. Can you paste the XML in here for the
com.ibm.team.process.deliver.requireWorkItemApproval precondition? You
can get that by opening the Process Configuration Source tab and
searching for that id.

Jared Burns
Jazz Process Team


abaror wrote:

We tried exactly this process , I created the rule and allowed to
override the review. After I approved, my team member tried to
deliver the workitem , however it was rejected by the rules that
requires approval. Looking again on the workitem, we can see it is
approved.
He was able to deliver it , but choosing to overrule the the review.


Is that a known defect or we are doing something wrong?

What also is strange, that he can open the workitem and remove the
required approvals.

We have 3 team areas in the project. For each team , we need a different review rule and a different person to review the changes. The suggested rule below is done in the project level. Is there a way to do it in the team level? Is there a way to define a team-lead role for a team area, not a project-lead?

Every team can customize their process. Expand the "Process
Customization" section of the team area editor and click "Customize the
process". At this point, you can define different preconditions which
will replace those defined in the project area. Each team can also
define new roles.

I would suggest reading "Getting Started with Jazz Project Areas and
Process" to get an overview of Process in Jazz:
https://jazz.net/learn/LearnItem.jsp?href=content/docs/process/index.html

Jared Burns
Jazz Process Team


abaror wrote:

We have 3 team areas in the project. For each team , we need a
different review rule and a different person to review the changes.
The suggested rule below is done in the project level. Is there a way
to do it in the team level? Is there a way to define a team-lead role
for a team area, not a project-lead?

Hi Jared,

Regarding your comment below - It is not clear to me how to set a precondition for approval "by role". It was my understanding that setting the precondition applied to the user role 'taking the action'. So, if I added a precondition for the 'Team Member', that would require the team member to gain approval before saving. Similarly, setting a precondition for 'Team Lead' would also just require that user to gain approval before saving. How/where would I specify the type of role that is required to grant approval?

Thanks,
Erin

There's no explicit notion of delegating reviews, but you could
accomplish this by configuring your precondition to require a team-lead
approval *and* a team-member approval.

Then your team could work like this:
1. Team member A attaches a change set to a work item and creates a
review request for the team-lead.
2. The team-lead sees this request in Team Central and decides to
delegate the review to team member B. The team-lead marks the team-lead
review as completed and creates a new review for team-member B.
3. Team member B reviews the changes and marks their review as completed.
4. With both reviews in hand, team member A can deliver the changes.

Jared Burns
Jazz Process Team


abaror wrote:

Can a team-lead than delegate the review of a specific workitem to
another team member?

The precondition allows to select a role that is required to do the approval.
If the approver does not satisfy the role requirements the approval does not count as approved.

Ralph

Hi Jared,

Regarding your comment below - It is not clear to me how to set a precondition for approval "by role". It was my understanding that setting the precondition applied to the user role 'taking the action'. So, if I added a precondition for the 'Team Member', that would require the team member to gain approval before saving. Similarly, setting a precondition for 'Team Lead' would also just require that user to gain approval before saving. How/where would I specify the type of role that is required to grant approval?

Thanks,
Erin

There's no explicit notion of delegating reviews, but you could
accomplish this by configuring your precondition to require a team-lead
approval *and* a team-member approval.

Then your team could work like this:
1. Team member A attaches a change set to a work item and creates a
review request for the team-lead.
2. The team-lead sees this request in Team Central and decides to
delegate the review to team member B. The team-lead marks the team-lead
review as completed and creates a new review for team-member B.
3. Team member B reviews the changes and marks their review as completed.
4. With both reviews in hand, team member A can deliver the changes.

Jared Burns
Jazz Process Team


abaror wrote:

Can a team-lead than delegate the review of a specific workitem to
another team member?