It's all about the answers!

Ask a question

[closed] [Announcement] Early version od Rational Team Concert - Review Board integration available

Jan Koprowski (11156) | asked Jun 11 '13, 2:31 a.m.
closed Oct 12 '17, 11:40 a.m. by David Lafreniere (4.8k7)


  I would like to announce early version of Rational Team Concert - Review Board integration.
  This integration gets change sets associated with work item and create review at configured Review Board server while moving work item to pre-configured state. It is independent from IDE/Client (works regardless you are using: Eclipse, Visual Studio, Windows Shell or Web client). As far as I know this is very first open-source review tool integration working with Jazz Source Control.
  I'm inviting to tests.



Jan Koprowski commented Jun 11 '13, 2:32 a.m. | edited Jun 11 '13, 2:34 a.m.

Source code and very brief instruction is availale here

David Lafreniere commented Oct 12 '17, 11:46 a.m.

This is just an observation, but to me it's not clear if the RTC Integration of 'Review Board' is maintained. The last commit was 4 years ago. (It very well might be the case that the current state of the code works perfectly fine in an RTC 6.x environment, but I cannot say)

The question has been closed for the following reason: "Problem is not reproducible or outdated" by daviddl Oct 12 '17, 11:40 a.m.

One answer

permanent link
David Lafreniere (4.8k7) | answered Oct 12 '17, 11:08 a.m.

I just wanted to add a comment for any readers that may stumble upon this forum post - As of RTC 6.0.1, there is a built-in Code Review tool.

Summary of the feature:

In Rational Team Concert 6.0.1 we have introduced a new Code Review feature. Code review is integrated with RTC work items and Jazz SCM to provide developers with a seamless, low overhead work flow that is simple to use and is a natural extension to their daily activities. There isn’t a separate server installation, additional licensing fees or other costs associated with using RTC code review. Enabling code review for your projects is simple and takes only a few minutes to set up.

Reviewers can annotate specific lines of code, which helps developers quickly see and fix issues. Issues (or findings) can be marked as must-fix and the reviewer can accept or reject the changes. When preconditions are enabled, a code review cannot be approved if must-fix issues have not been resolved to everyone’s satisfaction.

Developers don’t have to worry about the intricacies of issue management because this is handled for them. Each issue has its own discussion thread and events are logged as the review progresses. Whenever an issue is updated, a new issue raised, or new code changes are added to the review, the events are logged so that you have a complete history of the review life-cycle. Because code reviews are iterative and can include code changes during the review cycle, any annotations on lines of code (issue markers) are automatically re-positioned and visual cues are provided to the reviewer so that they can easily see what has changed since they last looked at the code or since they last reviewed issues.

Team collaboration is accelerated through real-time notification of pending reviews, issues, and fixes. This is becoming more and more important as the number of globally distributed development teams increase. In fact, with the RTC SCM development team spread across three different time zones, it is common for them to have code changes that were written in one time zone reviewed by team members in another time zone.

Code review enables auditing for compliance. Issue status at delivery, approval information, the event logs, and other information captured during the review can be used for a variety of metrics and reporting requirements.

Since the introduction of code review in 6.0.1 more features have been added. Reviewers can inspect intermediate before and after file states which is useful in advanced SCM workflows encountered when multiple developers are working on a common code base. We have added the ability to filter issues on the navigator pane on the left, and various usability enhancements have been added.

The ability to extract work items is useful when an issue needs to be addressed but shouldn’t prevent delivery of the current code changes. The extracted work item captures the required work and will have its own code review cycle.

A SCM CLI command is also available to export code review data such as issues raised, issue activity, reviewer information, code delivery status, and other metrics in JSON or XML format. This enables customers to use their existing reporting tools or custom scripts for auditability and other reporting requirements

Additional Information:
Article: Rational Team Concert Code Review
Video: Introduction to Code Review (Part 1)
Video: Configuring Code Review (Part 2)
Video: Performing a Code Review (Part 3)
Knowledge Center: Working With the Code Review Tool