It's all about the answers!

Ask a question

How to get Notification for code review


sandeep srivastava (1143) | asked Apr 01 '08, 7:50 a.m.
Hi,

We are using the Jazz client for our project. As per our developer best practices , we review the code before push to severe. So how we can do this process in Jazz.

1. Developer change the code , she need to send her changes to team lead, using jazz how she can do it.
2. In what way team lead will get the review link in Jazz, How he can see the changes that a developer made,and how he can send his review comment back to developer.

3 answers



permanent link
Jared Burns (4.5k29) | answered Apr 01 '08, 4:08 p.m.
FORUM ADMINISTRATOR / FORUM MODERATOR / JAZZ DEVELOPER
One way you could do this would be:

1. (New feature coming in M6 this week) Add a precondition to the
deliver operation which requires that all change sets be associated with
a workitem which has an approved review.
2. When a team member has code they're ready to deliver, the attach a
change set with their edits to a workitem and add an approval request to
the workitem of type Review.
3. Each team member adds a query to Team Central which shows them all
pending review requests.

--
Jared Burns
Jazz Process Team

sandeep.1.srivastava wrote:
Hi,

We are using the Jazz client for our project. As per our developer
best practices , we review the code before push to severe. So how we
can do this process in Jazz.

1. Developer change the code , she need to send her changes to team
lead, using jazz how she can do it.
2. In what way team lead will get the review link in Jazz, How he can
see the changes that a developer made,and how he can send his review
comment back to developer.

Comments
Francis Gavino commented Aug 07 '08, 1:43 a.m. | edited Jan 29 '20, 12:04 p.m.

Jared,

How about the other question: <i:08625c48ad>how he can send his review
comment back to developer</i:08625c48ad>?
I would imagine a nice feature where the comments are linked to specific lines of the code being reviewed, and there are exportable lists of review comments for a work item, review iterations/workflow, rework responses, etc. And then link this to the &quot;Approval&quot; feature of jazz before the developer can deliver his work.
There's an eclipse plug-in with some of these features (search for Jupiter), but it would really be nice to have this integrated in jazz.

.Francis


One way you could do this would be:

1. (New feature coming in M6 this week) Add a precondition to the
deliver operation which requires that all change sets be associated with
a workitem which has an approved review.
2. When a team member has code they're ready to deliver, the attach a
change set with their edits to a workitem and add an approval request to
the workitem of type Review.
3. Each team member adds a query to Team Central which shows them all
pending review requests.

--
Jared Burns
Jazz Process Team

sandeep.1.srivastava wrote:
Hi,

We are using the Jazz client for our project. As per our developer
best practices , we review the code before push to severe. So how we
can do this process in Jazz.

1. Developer change the code , she need to send her changes to team
lead, using jazz how she can do it.
2. In what way team lead will get the review link in Jazz, How he can
see the changes that a developer made,and how he can send his review
comment back to developer.


Wang Jian Qiu commented Aug 07 '08, 3:13 a.m. | edited Jan 29 '20, 12:04 p.m.
One way you could do this would be:
dfsdfsdfs
1. (New feature coming in M6 this week) Add a precondition to the
deliver operation which requires that all change sets be associated with
a workitem which has an approved review.
2. When a team member has code they're ready to deliver, the attach a
change set with their edits to a workitem and add an approval request to
the workitem of type Review.
3. Each team member adds a query to Team Central which shows them all
pending review requests.

--
Jared Burns
Jazz Process Team

sandeep.1.srivastava wrote:
Hi,

We are using the Jazz client for our project. As per our developer
best practices , we review the code before push to severe. So how we
can do this process in Jazz.

1. Developer change the code , she need to send her changes to team
lead, using jazz how she can do it.
2. In what way team lead will get the review link in Jazz, How he can
see the changes that a developer made,and how he can send his review
comment back to developer.

permanent link
Jared Burns (4.5k29) | answered Aug 07 '08, 2:49 p.m.
FORUM ADMINISTRATOR / FORUM MODERATOR / JAZZ DEVELOPER
Hi, Francis.

RTC doesn't currently ship with this level of code review integration,
though it would make a nice addition.

Currently, a reviewer can express &quot;annotations&quot; to the code by attaching
a change set to the work item. The way my team works, we write up our
prose explanation as a comment on the work item and attach a change set
with the actual changes that we recommend. This way, if the original
developer agrees with the changes, they can simply accept the change set
and deliver it as-is.

But if you want line-by-line comments on the code, I think the best you
could do would be to attach a change set which added comments to the
code. This change set would never actually be delivered, of course, but
it would allow developers to walk through the in-line annotations.

Jared Burns
Jazz Process Team


francis.gavino wrote:
Jared,

How about the other question: how he can send his
review
comment back to developer?
I would imagine a nice feature where the comments are linked to
specific lines of the code being reviewed, and there are exportable
lists of review comments for a work item, review iterations/workflow,
rework responses, etc. And then link this to the &quot;Approval&quot;
feature of jazz before the developer can deliver his work.
There's an eclipse plug-in with some of these features (search for
Jupiter), but it would really be nice to have this integrated in
jazz.

Francis


jburnswrote:
One way you could do this would be:
1. (New feature coming in M6 this week) Add a precondition to the
deliver operation which requires that all change sets be associated
with
a workitem which has an approved review.
2. When a team member has code they're ready to deliver, the attach
a
change set with their edits to a workitem and add an approval
request to
the workitem of type Review.
3. Each team member adds a query to Team Central which shows them
all
pending review requests.

--
Jared Burns
Jazz Process Team

sandeep.1.srivastava wrote:
Hi,

We are using the Jazz client for our project. As per our developer
best practices , we review the code before push to severe. So how
we
can do this process in Jazz.

1. Developer change the code , she need to send her changes to team
lead, using jazz how she can do it.
2. In what way team lead will get the review link in Jazz, How he
can
see the changes that a developer made,and how he can send his
review
comment back to developer.


Comments
Francis Gavino commented Aug 08 '08, 6:56 a.m. | edited Jan 29 '20, 12:05 p.m.

Thanks Jared for the tips. I'll just submit an enhancement request for the code review integration.

.Francis


permanent link
David Lafreniere (4.7k7) | answered Jan 29 '20, 12:06 p.m.
FORUM MODERATOR / JAZZ DEVELOPER

In Rational Team Concert 6.0.1 we have introduced a new Code Review feature. (Note: Every release additional enhancements have been added, with many new workflow improvements added in 7.0).

Code review is integrated with RTC work items and Jazz SCM to provide developers with a seamless, low overhead work flow that is simple to use and is a natural extension to their daily activities. There isn’t a separate server installation, additional licensing fees or other costs associated with using RTC code review. Enabling code review for your projects is simple and takes only a few minutes to set up.

Reviewers can annotate specific lines of code, which helps developers quickly see and fix issues. Issues (or findings) can be marked as must-fix and the reviewer can accept or reject the changes. When preconditions are enabled, a code review cannot be approved if must-fix issues have not been resolved to everyone’s satisfaction.

Developers don’t have to worry about the intricacies of issue management because this is handled for them. Each issue has its own discussion thread and events are logged as the review progresses. Whenever an issue is updated, a new issue raised, or new code changes are added to the review, the events are logged so that you have a complete history of the review life-cycle. Because code reviews are iterative and can include code changes during the review cycle, any annotations on lines of code (issue markers) are automatically re-positioned and visual cues are provided to the reviewer so that they can easily see what has changed since they last looked at the code or since they last reviewed issues.

Team collaboration is accelerated through real-time notification of pending reviews, issues, and fixes. This is becoming more and more important as the number of globally distributed development teams increase. In fact, with the RTC SCM development team spread across three different time zones, it is common for them to have code changes that were written in one time zone reviewed by team members in another time zone.

Code review enables auditing for compliance. Issue status at delivery, approval information, the event logs, and other information captured during the review can be used for a variety of metrics and reporting requirements.

Since the introduction of code review in 6.0.1 more features have been added. Reviewers can inspect intermediate before and after file states, which is useful in advanced SCM workflows encountered when multiple developers are working on a common code base. We have added the ability to filter issues on the navigator pane on the left, add tags to issues, and various usability enhancements have been added.

The ability to extract work items is useful when an issue needs to be addressed but shouldn’t prevent delivery of the current code changes. The extracted work item captures the required work and will have its own code review cycle.

A SCM CLI command is also available to export code review data such as issues raised, issue activity, reviewer information, code delivery status, and other metrics in JSON or XML format. This enables customers to use their existing reporting tools or custom scripts for auditability and other reporting requirements

Additional Information:
Article: Rational Team Concert Code Review
Video: Introduction to Code Review (Part 1)
Video: Configuring Code Review (Part 2)
Video: Performing a Code Review (Part 3)
Knowledge Center: Working With the Code Review Tool

Your answer


Register or to post your answer.