Code Review process
![]()
Hi,
We are planning import to RTC 3.0.1 I saw topics about Code Review but didn't understand RTC way for Code Review process. (we don't have external tools). RTC built-in features for Code Review (what I know): - WI Approval - Deliver CS related to approval WI only - Accept CS by WI from any stream - Right click on CS -> 'submit for review' - relate CS to WI, complete CS, create approval field on WI RTC Code Review process (That's how I understand, But I have some problems and I need your help): 1) There is one Code reviewer for many streams on our system. 2) Developer create CS and 'submit for review' - the CS completed 3) Code Review want fix for the CS so write WI commnt @developer 4) Developer correct the CS (new CS created) 'submit for review' (CS completed) 5) Code Reviewer sign WI approvals. now the developer can 'deliver' the CS. Problems: 1. How to replay the process for more than one CS (WI contains more than one CS and already signed) 2. Fixed CS is not related to original CS so after approval, one can deliver only the original without the fix. 3. Many Approvals fields (for each 'submit for review') Can you please explain the Code Review process? Thanks, Yehiel |
4 answers
![]()
Hi.
I think developer should set the CS completed when submitting for review. If the CS is active, developer can checks-in to the same CS freely, so, reviewed code and submitted code may be different. ("Submit for review" action automatically changes the CS state from active to completed. This behavior is reasonable.) Because we can't check-in to the completed CS, developer needs to create a new CS. ( Developer can't do the following step - 'D1 fixes the code in f2 based on D3's review and checks in to the same changeset. ' ) In this case, how can we deal with the problem 2 yehiel-san says ? Developer needs to deliver 2 CSs( the original and the fix) at the same time. How can we restrict that developer delivers only the original without the fix ? Thanks. |
![]()
Hello, I'm planning to migrate, and we did some test beforehand on how to use RTC source code management. The thing is that the alternatives I saw for a code inspection do not sound to me efficient. As an example, If I want to set up a review of ~15 files, I include them in a changeset, how can a reviewer make comments to a particular line in a particular file, and how the same reviewer can make an efficient follow up comment by comment and line by line?
We were using ReviewBoard and the tool worked really well for our process, so I'm trying to see how RTC can help me use the (more or less) same process. Thanks, Comments As @tmok mentioned to you in another thread, we don't currently support ReviewBoard, though some enhancement requests have been filed to track the possibility of doing so. I'm not aware of any capability that is currently available that would allow annotation directly in the source without creating a new change set or patch. Finding the ReviewBoard work items, commenting on and socializing them to promote a desire to add ReviewBoard to RTC is likely the best path forward. Do you have some examples of the enhancement requests? Is just to know when are those planned for.
|
![]()
Millard Ellingsworth (2.5k●1●24●31)
| answered Feb 27 '13, 3:29 p.m.
FORUM ADMINISTRATOR / JAZZ DEVELOPER
Here are the work items that are tracking a possible ReviewBoard integration. A ReviewBoard contributor discusses their plans to work on an RTC integration in the first one. Both of these items are sitting on the backlog at this time.
https://jazz.net/jazz/resource/itemName/com.ibm.team.workitem.WorkItem/248348
https://jazz.net/jazz/resource/itemName/com.ibm.team.workitem.WorkItem/242139
|
Your answer
Dashboards and work items are no longer publicly available, so some links may be invalid. We now provide similar information through other means. Learn more here.