Submitting your changes for code review

As an author to begin a code review process, you must first submit your changes for review. To submit a completed change set for review, associate it with a work item and specify team members to review it. The following procedure explains how to initiate the code review process by using the Eclipse client.

Before you begin

Ensure that your project area is configured with code review before you submit your changes. If not configured, contact your project area administrator to configure your project area for code review.
Note: You can still use the Submit for review action by using an older client (before 7.0). The process is the same except that approvals are added to the work item approvals tab and the code review tab. You can remove the work item approvals if needed as they are not related to the new code review workflow.

About this task

The typical workflow starts, when a work item is assigned to an author. The author then creates change sets to complete the work item and initiates the code review by using the Submit for Review action.

Procedure

  1. As an author, in the Pending Changes view, select the changes sets for review, right-click the selection, and click Submit for Review.
    Note: The Submit for Review action is enabled only if the change set is in a repository workspace that is flowing with a stream. If it flows to another workspace, or has no flow target you cannot submit for review.
  2. If a work item is not associated with the change set, the Submit Change Sets for Review window prompts you to do so.
    For more information, see Associating change sets with work items.
  3. In the Submit for Review window:
    1. To suspend the change sets while you await responses from reviewers, select Suspend change sets.
    2. Optional: Enter a brief comment to be added to the work item.
    3. In the Reviewers section, click Add to add reviewers.
      In the Enter user name field, enter a text string and click Search to search for the name of a reviewer. Click to select one or more (use Ctrl key) reviewers in the Matching users field, click Select and then, click OK.
    4. Optional: By default, the target is set as your workspace stream. You can change the target stream if required.
  4. After you added the reviewers, click Finish.
    You can view the code review summary and open the code review page from the code review tab, in the work item view of the Eclipse client. The code review presentation is displayed according to the configuration settings done by your project area administrator. It is usually added to the Code Review tab for ease of access and usability.code_review_tab_eclipse

Results

The author is not allowed to add or remove change sets while code review status is 'In Review'. The reviewers receive an email notification with the link to access the code review page and the work item details.

What to do next

The next steps involve the actual process of conducting a code review that takes place in the web client.