It's all about the answers!

Ask a question

Required Approvals Precondition - Multiple reviews


Rich Pastuch (2197) | asked Dec 20 '11, 4:33 p.m.
I have configured the Required Approvals Precondition as follows.

1) Required for a Task in the In Progress state.
2) Required approvals are Review - Approved.

If I have only one Review and the Review is in the Pending state, I correctly receive an error message when I attempt to move the work item to the In Progress state.

If I have two Reviews, one Review in the Pending state and one Review in the Approved state, I am able to move the work item to the In Progress state. This does not seem correct. I would have expected to receive an error message because all Reviews were not in the required state of Approved.

Is this a bug?

Thanks.

7 answers



permanent link
Frank Ning (50025119133) | answered Mar 14 '13, 11:27 a.m.

In RTC 4.0.1, it says the following for "Required Approvals" precondition of the "Save Work Item (server)" operation.

"Verifies that a work item can only be saved if all required approvals are in the configured state."

So it should apply to all the approval records. However, I am not able to specify roles as I can with the "Deliver (Server)" operation. The enhancement for that is opened:

https://jazz.net/jazz/web/projects/Rational%20Team%20Concert#action=com.ibm.team.workitem.viewWorkItem&id=255938


permanent link
Daniel Toczala (88211514) | answered Feb 20 '13, 9:49 a.m.
FORUM MODERATOR / JAZZ DEVELOPER
 I know of another customer that has used the team Configuration -> Operation Behavior section, and selected Source Control -> Deliver (client), and used the Require Work Item Approval precondition.  They then made sure that any code delivery was essentially signed off by at least one person in the architect role, and two people in the developer role.  This was their way of enforcing some sort of design/code review of any code changes.

With this precondition, you can set the minimum number of approvals from each role that are required.  You should definitely play around with this on a test system/project, so you understand how it works, before attempting to deploy this in one of your active projects.

permanent link
Fausto Lemos (16811518) | answered Dec 21 '11, 8:59 a.m.
Hi Geoff,

setting two people as approvers sove only one part of the problem.

What i think Rich (and me too) wants to do is two approvals (independent of his type), for example, "approve if code is ok?" and "revision documentation is ok?" and RTC checks if both are approved to allow state change.

Actually (as you said) at RTC you can only choose: state A, B and C need approvals.

Create 3 approvals.

Approve only one.

Try to change WI state between A,B,C and everything goes ok!

Thats because RTC don't link the approval with the state, he just look quantity.

If RTC give us a way to link a approval with a state it will be nice.



Geoff,

My scenario is that I have different types of aprovals (e.g., Code Review, Design Review, SME Review). I need to track, report, and enforce these different types of approvals.

Thanks.

Rich

The Required Approvals precondition says that "at least one of the
specified approvals must exist" (not "all of the specified approvals
must exist").

To require that both people approve, you wouldn't create two approvals
.... instead, you would create one approval with two approvers. What
matters is the overall state of an approval, and that doesn't go to
"approved" until all approvers of that approval have approved it.

Cheers,
Geoff


permanent link
Rich Pastuch (2197) | answered Dec 21 '11, 8:09 a.m.
Geoff,

My scenario is that I have different types of aprovals (e.g., Code Review, Design Review, SME Review). I need to track, report, and enforce these different types of approvals.

Thanks.

Rich

The Required Approvals precondition says that "at least one of the
specified approvals must exist" (not "all of the specified approvals
must exist").

To require that both people approve, you wouldn't create two approvals
.... instead, you would create one approval with two approvers. What
matters is the overall state of an approval, and that doesn't go to
"approved" until all approvers of that approval have approved it.

Cheers,
Geoff


permanent link
Geoffrey Clemm (30.1k33035) | answered Dec 21 '11, 12:08 a.m.
FORUM ADMINISTRATOR / FORUM MODERATOR / JAZZ DEVELOPER
The Required Approvals precondition says that "at least one of the
specified approvals must exist" (not "all of the specified approvals
must exist").

To require that both people approve, you wouldn't create two approvals
.... instead, you would create one approval with two approvers. What
matters is the overall state of an approval, and that doesn't go to
"approved" until all approvers of that approval have approved it.

Cheers,
Geoff

On 12/20/2011 4:38 PM, rpastuch wrote:
I have configured the Required Approvals Precondition as follows.

1) Required for a Task in the In Progress state.
2) Required approvals are Review - Approved.

If I have only one Review and the Review is in the Pending state, I
correctly receive an error message when I attempt to move the work
item to the In Progress state.

If I have two Reviews, one Review in the Pending state and one Review
in the Approved state, I am able to move the work item to the In
Progress state. This does not seem correct. I would have expected
to receive an error message because all Reviews were not in the
required state of Approved.

Is this a bug?

Thanks.

permanent link
Fausto Lemos (16811518) | answered Dec 20 '11, 8:06 p.m.
Hi Rich,

i face this problem too and it looks like more an enhancement.

They could add an extra field at approvals form (besides type, description, etc) where te user will set the state wich this approval is linked with. So when users try to change WI state, RTC search for all approvals linked with that target state and verify if they are approved.

For now i think only advisor could save us! eheheheh

[]s
Fausto



I have configured the Required Approvals Precondition as follows.

1) Required for a Task in the In Progress state.
2) Required approvals are Review - Approved.

If I have only one Review and the Review is in the Pending state, I correctly receive an error message when I attempt to move the work item to the In Progress state.

If I have two Reviews, one Review in the Pending state and one Review in the Approved state, I am able to move the work item to the In Progress state. This does not seem correct. I would have expected to receive an error message because all Reviews were not in the required state of Approved.

Is this a bug?

Thanks.

permanent link
Geoffrey Clemm (30.1k33035) | answered Dec 21 '11, 9:23 a.m.
FORUM ADMINISTRATOR / FORUM MODERATOR / JAZZ DEVELOPER
You can currently use the Required Approvals precondition to require 1
of each of the 3 types of approvals (i.e. Approval, Review, and
Verification).

But to require more than one of a given type of approval (or to require
approvals with particular Subjects), you would need to implement your
own custom precondition. Also, feel free to submit a work item
describing the particular precondition that you'd like to see provided.

Cheers,
Geoff

On 12/21/2011 8:23 AM, rpastuch wrote:
Geoff,

My scenario is that I have different types of aprovals (e.g., Code
Review, Design Review, SME Review). I need to track, report, and
enforce these different types of approvals.

Thanks.

Rich

gmclemmwrote:
The Required Approvals precondition says that "at least one of
the
specified approvals must exist" (not "all of the specified
approvals
must exist").

To require that both people approve, you wouldn't create two
approvals
.... instead, you would create one approval with two approvers.
What
matters is the overall state of an approval, and that doesn't go to

"approved" until all approvers of that approval have
approved it.

Cheers,
Geoff


Your answer


Register or to post your answer.


Dashboards and work items are no longer publicly available, so some links may be invalid. We now provide similar information through other means. Learn more here.