It's all about the answers!

Ask a question

How to require a review for every change set linked to a work item

Leigh Light (33269) | asked Jul 29 '13, 2:41 p.m.
The process configuration for our project area is set to require a single (1) review before a change set can be delivered to the stream.  Our coders have discovered that the single review requirement is applied to the Task Work Item and not to the change sets.  In other words, as long as a Task Work Item has one approved review in it's approval tab, all change sets linked to the Work Item can be delivered to the stream.

We want to enforce a policy of a single (1) review for every change set. Does anyone know how we can configure our project area to enforce this requirement?

Any ideas on how to resolve this issue are welcome.


Geoffrey Clemm commented Sep 16 '13, 9:57 p.m.

Why would you want to require a separate review for each change set for a work item?  In particular, there are various reasons why you would need to create several change sets to complete a given work item, and reviewing each one of them separately would make no sense (only the combination of all of the change sets would make semantic sense).

2 answers

permanent link
Surya Tripathi (65017) | answered Jul 29 '13, 4:18 p.m.
I do not believe project/team configuration provides that level of granularity out of the box. But, you can add X number of required approvers where X is the maximum number of change sets associated with a work item. Of course, this will require predicting how many change sets will be added to the work items.

To provide an exact solution to your problem, you would need to write your own process advisor which will return false upon deliver (hence failing the deliver op) if number of change sets are more than the number of approvals. It is still not possible, in my opinion to relate which approval is for which change set. Feel free to submit an enhancement request.

permanent link
Tim Mok (6.6k38) | answered Jul 29 '13, 4:14 p.m.
There isn't a precondition that can enforce that kind of policy. There are external code review systems that might provide the integration you want for that kind of policy. SmartBear is one of them. Someone recently posted about a ReviewBoard integration. I don't know much about either but it's worth checking out.

There are other preconditions that might provide an acceptable work flow. You can look at the "Prevent Linking to Approved Work Items" precondition and split your work items so that change sets associated with a work item are reviewed by one person. It requires more micromanagement with your work items but you can stop developers from attaching change sets to work items that have already been approved. Any approvers must review all change sets attached and reject the approval if there are change sets they aren't supposed to review.

Your answer

Register or to post your answer.

Dashboards and work items are no longer publicly available, so some links may be invalid. We now provide similar information through other means. Learn more here.